PHP changes
- Combine DB calls as much as possible
- Remove absolute server links and make relational.
- Add a namespace and remove all global vars, unless specifically needed.
- Separate presentation from functionality. Controller page and then include the html needed for that view. View functionality like repeating table rows can go in the view page, any logic needs to stay in the php page. All formatting and layout of the view should be in the html/css.
- Organize the php and move vars to the top of the section
- Securely screen all incoming form data, and then sql screen before sending to db.
Files to change
- request_form.php
- confirmation.php
- admin/index.php
- admin/actions.php
- admin/feed/index.php
- dashboard\includes\approve\cur_fis_year.php
- dashboard\includes\approve\cur_month.php
- dashboard\includes\approve\cur_year.php
- dashboard\includes\approve\past_30days.php
- dashboard\includes\approve\past_week.php
- dashboard\includes\length\cur_fis_year.php
- dashboard\includes\length\cur_month.php
- dashboard\includes\length\cur_year.php
- dashboard\includes\length\past_30days.php
- dashboard\includes\length\past_week.php
- dashboard\list_results.php
- dashboard\results.php